Skip to content

Conversation

@driazati
Copy link
Member

@driazati driazati commented Jun 7, 2022

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@mehrdadh
Copy link
Member

mehrdadh commented Jun 7, 2022

Please don't merge this since hexagon tests are skipped in the CI at the moment.

@mehrdadh
Copy link
Member

mehrdadh commented Jun 7, 2022

let's wait for this(#11613) and rerun this PR

@mehrdadh
Copy link
Member

mehrdadh commented Jun 8, 2022

@driazati can you rerun this since #11613 is merged?

@quic-sanirudh
Copy link
Contributor

@driazati can you rerun this since #11613 is merged?

@driazati Can you try re-running this patch. I tried re-running #11588, but it did not build the new docker tag and instead it built the old one. If I try it locally, I'm able to both build hexagon docker with the new tag and run the hexagon ci tests.

@driazati
Copy link
Member Author

driazati commented Jun 9, 2022

(sorry was out yesterday so I missed these), rebased and pushed so it should have the new fix (Jenkins will only load the Jenkinsfile from certain trusted forked repositories which is why it didn't use the new Docker image for you, pushing to a branch in apache/tvm as the source for your PR would get around that)

@quic-sanirudh
Copy link
Contributor

quic-sanirudh commented Jun 10, 2022

(sorry was out yesterday so I missed these), rebased and pushed so it should have the new fix (Jenkins will only load the Jenkinsfile from certain trusted forked repositories which is why it didn't use the new Docker image for you, pushing to a branch in apache/tvm as the source for your PR would get around that)

@driazati Thanks a lot for the explanation and in helping verify our PR.

@driazati driazati closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants