[Pylint] Pylint integration_tests folder #11672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asparkhi
reviewed
Jun 13, 2022
AndrewZhaoLuo
force-pushed
the
aluo/pylint/integration-tests
branch
from
9811e4e to
e2f00a2
Compare
AndrewZhaoLuo
changed the title
AndrewZhaoLuo
force-pushed
the
aluo/pylint/integration-tests
branch
from
23408a4 to
a6a04db
Compare
Contributor
Author
|
@ashutosh-arm this is now ready for review |
AndrewZhaoLuo
force-pushed
the
aluo/pylint/integration-tests
branch
from
a6a04db to
81d3b1c
Compare
asparkhi
reviewed
Jun 24, 2022
Contributor
asparkhi
left a comment
asparkhi
left a comment
There was a problem hiding this comment.
Thanks @AndrewZhaoLuo. Looks nice 👍 . Just a few nits and queries.
| @T.prim_func | ||
| def tensorcore_gemm(a: T.handle, b: T.handle, c: T.handle) -> None: | ||
| def tensorcore_gemm(handle_a: T.handle, handle_b: T.handle, handle_c: T.handle) -> None: | ||
| # pylint: disable=missing-function-docstring |
Contributor
There was a problem hiding this comment.
Are we not able to get rid of it?
Contributor
Author
There was a problem hiding this comment.
this is tir script or whatever it's called, we can't actually insert a docstring since the parser does not handle it
|
|
||
| @autotvm.template("testing/conv2d_no_batching") | ||
| def conv2d_no_batching(N, H, W, CI, CO, KH, KW): | ||
| def conv2d_no_batching( # pylint: disable=unused-variable |
Contributor
There was a problem hiding this comment.
Not able to remove the pylint disable?
Contributor
Author
There was a problem hiding this comment.
the function isn't used so yeah unfortunately not :/, however it is registered in the big autotvm task table or something
AndrewZhaoLuo
force-pushed
the
aluo/pylint/integration-tests
branch
from
81d3b1c to
a439386
Compare
Contributor
Author
|
PTAL @ashutosh-arm |
masahi
approved these changes
Jul 7, 2022
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* add folder to pylint * add init py * lint test_arm_mrpofile_dsp.py * one more change to tests/python/integratoin/test_arm_mprofile_dsp.py * add test_dot * test_ewise_fpga.py * test_ewise.py * test gemm * test_lower.py * test_meta_schedule_auto_tensorize.py * test_reduce.py pt1 * test_reduce.py pt2 * test_scan.py * test_tuning.py * test_winograd_nnpack.py * final test pass * comments * clean up test_lower more
junrushao
pushed a commit
to yelite/tvm
that referenced
this pull request
Jul 27, 2022
* add folder to pylint * add init py * lint test_arm_mrpofile_dsp.py * one more change to tests/python/integratoin/test_arm_mprofile_dsp.py * add test_dot * test_ewise_fpga.py * test_ewise.py * test gemm * test_lower.py * test_meta_schedule_auto_tensorize.py * test_reduce.py pt1 * test_reduce.py pt2 * test_scan.py * test_tuning.py * test_winograd_nnpack.py * final test pass * comments * clean up test_lower more
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* add folder to pylint * add init py * lint test_arm_mrpofile_dsp.py * one more change to tests/python/integratoin/test_arm_mprofile_dsp.py * add test_dot * test_ewise_fpga.py * test_ewise.py * test gemm * test_lower.py * test_meta_schedule_auto_tensorize.py * test_reduce.py pt1 * test_reduce.py pt2 * test_scan.py * test_tuning.py * test_winograd_nnpack.py * final test pass * comments * clean up test_lower more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11414