[Arith] Update BufferDomainTouched to support vector access. #11722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
approved these changes
Jun 15, 2022
Contributor
|
It also fixes the original failing testcase. |
Contributor
|
Ping. There is only a simple build issue due to a declaration of an unused variable... |
Contributor
Author
|
Thanks @kparzysz-quic, didn't have time to circle back last week unfortunately but I have returned from PTO today and will send a patch to land this as soon as possible. |
Contributor
|
Thanks @csullivan! |
zxybazh
pushed a commit
to zxybazh/tvm
that referenced
this pull request
Jun 26, 2022
…11722) * [Arith] Update BufferDomainTouched to support vector access. * Add test checking that domain touched works on IR containing RampNodes.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…11722) * [Arith] Update BufferDomainTouched to support vector access. * Add test checking that domain touched works on IR containing RampNodes.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…11722) * [Arith] Update BufferDomainTouched to support vector access. * Add test checking that domain touched works on IR containing RampNodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also loosen the requirement that the user provided buffer exist within the IR to match with the old behavior of DomainTouched.
Resolves #11716