[ci][docker] Fall back to tlcpackstaging if images don't exist #11775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2022
Member
Author
|
@tvm-bot rerun |
areusch
approved these changes
Jun 22, 2022
| ) | ||
| parser.add_argument( | ||
| "--base-dir", | ||
| default=".docker-image-names", |
Contributor
There was a problem hiding this comment.
should this be relative to repo root?
Member
Author
There was a problem hiding this comment.
in tests it needs to be off in a random tempdir (and that's the only place this is really used)
Contributor
|
Built docs for commit 9240ff20484c07f896cb4a3d6ed0cfb9be3b5a79 can be found here. |
leandron
pushed a commit
that referenced
this pull request
Jul 1, 2022
This uses #11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <driazati@users.noreply.github.com>
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…e#11775) See apache#11768. This adds a script to check if Docker images exist in `tlcpack` and switch to `tlcpackstaging` if not (the tags must match though). There is also a feature flag for this in jenkins in the `DETERMINE_DOCKER_IMAGES` env variable (which must be set to `yes` for this change to work)
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <driazati@users.noreply.github.com>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <driazati@users.noreply.github.com>
driazati
added a commit
that referenced
this pull request
Aug 11, 2022
See #11768, this PR changes the deploy workflow so that after a successful build with fallback images (see #11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This uses apache#11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack Co-authored-by: driazati <driazati@users.noreply.github.com>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
See apache#11768, this PR changes the deploy workflow so that after a successful build with fallback images (see apache#11775), they get moved over to tlcpack automatically. Since the images are moving repositories we can't just rename the blobs in docker, so there needs to be a full `pull -> tag -> push` for each image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11768. This adds a script to check if Docker images exist in
tlcpackand switch totlcpackstagingif not (the tags must match though). There is also a feature flag for this in jenkins in theDETERMINE_DOCKER_IMAGESenv variable (which must be set toyesfor this change to work)cc @Mousius @areusch