[ci] Redirect sphinx-gallery URLs to S3 #11839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
added a commit
that referenced
this pull request
Jun 24, 2022
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in #11839
Contributor
Contributor
zxybazh
pushed a commit
to zxybazh/tvm
that referenced
this pull request
Jun 26, 2022
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
guberti
reviewed
Jun 27, 2022
Member
guberti
left a comment
guberti
left a comment
There was a problem hiding this comment.
Big fan of this PR! Thanks for the change!
areusch
reviewed
Jun 28, 2022
python/tvm/testing/utils.py
Outdated
| msg += f"no file\n" | ||
|
|
||
| if base is None: | ||
| hook_script_dir = Path.cwd().resovle() |
| raise RuntimeError(f"Directory {hook_script_dir} does not exist:\n{msg}") | ||
|
|
||
| # Import the hook and start it up (it's not included here directly to avoid | ||
| # keeping a database of URLs inside the tvm Python package |
Contributor
There was a problem hiding this comment.
why not just make the database into a datafile? e.g. load from JSON or ast.literal_eval()?
Member
Author
There was a problem hiding this comment.
that seems like the complexity is the same as this method (i.e. find a file, load it up) but more limited in functionality. I updated the list to de-duplicate the S3 bucket name to make it clearer the use of keeping it all Python
Contributor
areusch
approved these changes
Jun 30, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
Co-authored-by: driazati <driazati@users.noreply.github.com>
areusch
pushed a commit
that referenced
this pull request
Jul 14, 2022
This follows on #11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
Co-authored-by: driazati <driazati@users.noreply.github.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This follows on apache#11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
Co-authored-by: driazati <driazati@users.noreply.github.com>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This follows on apache#11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks into
urllibso we can redirect certain URLs used in CI to more reliable copies in S3. This method catches everything, even urls hidden inside third-party modules (likeoneflow). This makes it so CI docs run with consistent speed and without the failures below. Items can be uploaded by any committer via this workflow. The S3 bucket is public, so users can still download the items if they want to exactly reproduce CI.Fixes #11918, fixes #11919, fixes #11811
cc @Mousius @areusch