[PyTorch] [Relay] Add aten::pad #11922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shingjan
commented
Jun 27, 2022
| "aten::replication_pad1d": self.make_pad("edge"), | ||
| "aten::replication_pad2d": self.make_pad("edge"), | ||
| "aten::replication_pad3d": self.make_pad("edge"), | ||
| "aten::pad": self.pad, |
Author
There was a problem hiding this comment.
Seems to me that only with this change test_forward_functional_pad was able to work on my local end, is this test disabled before on CI? This is also the reason why I am not adding a new test case. @masahi
Member
There was a problem hiding this comment.
They should be tested. There are tests like test_forward_constant_pad1d and test_forward_reflection_pad1d() in pytorch/test_forward.py.
Can you test on PT 1.10? This is the version we use on CI. From our earlier conversation, I'm guessing that aten::pad is not in PT 1.10, so we cannot test his on CI.
added 2 commits
June 27, 2022 12:02
masahi
approved these changes
Jun 28, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* add aten::pad * fix * fix CI
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* add aten::pad * fix * fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add
aten::padin the pytorch frontend and refactor the padding-related ops.cc: @masahi