Skip to content

Conversation

@mbs-octoml
Copy link
Contributor

This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.

@mbs-octoml mbs-octoml force-pushed the mbs-collage-index-in-spans branch from 0009ecc to 408d419 Compare June 28, 2022 00:16
Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming CaptureIndexInSpans() to CapturePostDFSOrderInSpans()? Since it's not clear what "Index" means.

Assuming they mean the same thing.

This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.
- add header decl
@mbs-octoml mbs-octoml force-pushed the mbs-collage-index-in-spans branch from 408d419 to 1b3eb16 Compare June 28, 2022 17:30
@mbs-octoml
Copy link
Contributor Author

Ready for submit once ci green, thank you.

@masahi
Copy link
Member

masahi commented Jun 28, 2022

@tvm-bot rerun

@masahi masahi merged commit a17bfc0 into apache:main Jun 28, 2022
@mbs-octoml mbs-octoml deleted the mbs-collage-index-in-spans branch June 29, 2022 16:59
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
* [Relay] CaptureIndexInSpans debugging pass

This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.

* - rename
- add header decl
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
* [Relay] CaptureIndexInSpans debugging pass

This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.

* - rename
- add header decl
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
* [Relay] CaptureIndexInSpans debugging pass

This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.

* - rename
- add header decl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants