Couple patches to docker/bash.sh after #11976. #11988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use python3 to run determine_docker_images.py * Properly detect presence of CI env var with + expansion.
driazati
approved these changes
Jul 1, 2022
| EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}") | ||
| if [ -n "${EXPANDED_SHORTCUT}" ]; then | ||
| if [ "${CI+x}" == "true" ]; then | ||
| if [ "${CI+x}" == "x" ]; then |
Member
There was a problem hiding this comment.
this seems to detect CI set to anything, rather than just true, is that intentional?
Contributor
Author
There was a problem hiding this comment.
with +x it merely evaluates to "x" if the var is set and nothing if not, iiuc
Contributor
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* Use python3 to run determine_docker_images.py * Properly detect presence of CI env var with + expansion.
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* Use python3 to run determine_docker_images.py * Properly detect presence of CI env var with + expansion.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* Use python3 to run determine_docker_images.py * Properly detect presence of CI env var with + expansion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leandron @mehrdadh @driazati