[Relay] Move TOpPattern registration for nn.* to C++ #12072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Collage machinery is best tested from C++, but requires Relay ops to have their "TOpPattern" registered. However since the nn.* ops register on the Python side tests can't rely on those ops. The easy fix is to just move the registration to the RELAY_REGISTER_OP block. However since kOpaque is the default I did not preserve those registrations. There's still a few dozen more exotic ops still registered on the Python side. I've left them be.
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* [Relay] Move TOpPattern registration for nn.* to C++ Some of the Collage machinery is best tested from C++, but requires Relay ops to have their "TOpPattern" registered. However since the nn.* ops register on the Python side tests can't rely on those ops. The easy fix is to just move the registration to the RELAY_REGISTER_OP block. However since kOpaque is the default I did not preserve those registrations. There's still a few dozen more exotic ops still registered on the Python side. I've left them be. * - D'oh! Even kOpaque ops must be registered.
junrushao
pushed a commit
to yelite/tvm
that referenced
this pull request
Jul 27, 2022
* [Relay] Move TOpPattern registration for nn.* to C++ Some of the Collage machinery is best tested from C++, but requires Relay ops to have their "TOpPattern" registered. However since the nn.* ops register on the Python side tests can't rely on those ops. The easy fix is to just move the registration to the RELAY_REGISTER_OP block. However since kOpaque is the default I did not preserve those registrations. There's still a few dozen more exotic ops still registered on the Python side. I've left them be. * - D'oh! Even kOpaque ops must be registered.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [Relay] Move TOpPattern registration for nn.* to C++ Some of the Collage machinery is best tested from C++, but requires Relay ops to have their "TOpPattern" registered. However since the nn.* ops register on the Python side tests can't rely on those ops. The easy fix is to just move the registration to the RELAY_REGISTER_OP block. However since kOpaque is the default I did not preserve those registrations. There's still a few dozen more exotic ops still registered on the Python side. I've left them be. * - D'oh! Even kOpaque ops must be registered.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [Relay] Move TOpPattern registration for nn.* to C++ Some of the Collage machinery is best tested from C++, but requires Relay ops to have their "TOpPattern" registered. However since the nn.* ops register on the Python side tests can't rely on those ops. The easy fix is to just move the registration to the RELAY_REGISTER_OP block. However since kOpaque is the default I did not preserve those registrations. There's still a few dozen more exotic ops still registered on the Python side. I've left them be. * - D'oh! Even kOpaque ops must be registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Collage machinery is best tested from C++, but
requires Relay ops to have their "TOpPattern" registered.
However since the nn.* ops register on the Python side tests
can't rely on those ops.
The easy fix is to just move the registration to the
RELAY_REGISTER_OP block.
There's still a few dozen more exotic ops still registered
on the Python side. I've left them be.