[Target] Add "features" property to Target #12121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
kparzysz-quic
approved these changes
Jul 19, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This adds a generated property "features" to the `Target` which can contain a read-only list of available features in line with apache/tvm-rfcs#78. Features are re-generated upon parsing into a `Target` object rather than being attached as `attrs`. The `Target` JSON is therefore stored without the inferred `features` attached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(On top of #12119)
This adds a generated property "features" to the
Targetwhich cancontain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a
Targetobject rather than beingattached as
attrs. TheTargetJSON is therefore stored without theinferred
featuresattached.