-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TFLite] Fix _test_tflite2_quantized_depthwise_convolution is unused #12145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @leandron, please have a look, thanks! |
|
also cc @NicolaLancellotti (as this might conflict with #12130) |
|
Also, these lines in tvm/tests/python/frontend/tflite/test_forward.py Lines 4590 to 4593 in eb7cf70
disable the following tests below test_forward_qnn_mobilenet_v3_net()tvm/tests/python/frontend/tflite/test_forward.py Lines 5106 to 5113 in eb7cf70
Can i put test_forward_qnn_mobilenet_v3_net() to the bottom?
|
I think @NicolaLancellotti 's #12130 has fixed the input name error, great! |
|
I will take a look tomorrow |
|
I will remove fix input_node name error when #12130 merged. |
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what I understand is the original tests in the issue were disabled since they were flaky. This issue seems closed now #6064 so it's fine to re-enable tests. However, due to some name change some additional code needs to be added to make the tests pass?
Seems fine to me, thanks for contribution.
…pache#12145) * Update test for tflite2_quantized_depthwise_convolution * fix input_node name error * Add entry for test_quantized_convolution * reformatted by black
As [Bug] _test_tflite2_quantized_depthwise_convolution is unused #11356 said. The entry of the
_test_tflite2_quantized_depthwise_convolutionhas been completed.And an input_node error has also been fixed, because the input name of the tflite model quantized by the
_quantize_keras_model()will be rewritten(no longerdata_in.name.replace(":0", ""))