Skip to content

Conversation

@yelite
Copy link
Contributor

@yelite yelite commented Jul 21, 2022

This PR:

  • Handle expression (operator) precedence during Python code printing ((* 1 (+ 2 3)) prints as 1 * (2 + 3))
  • Addresses remaining feedback from previous PR [TVMScript] StmtDoc Printing #12112
  • Reformats Python import with isort

Tracking issue: #11912

cc @junrushao1994 @gbonik

@github-actions github-actions bot requested a review from junrushao July 21, 2022 04:00
@yelite yelite force-pushed the tunip-expr-associativity branch 2 times, most recently from d88bcc7 to d2f87f8 Compare July 25, 2022 18:24
@junrushao junrushao force-pushed the tunip-expr-associativity branch 2 times, most recently from a3584aa to 90b3a9c Compare July 27, 2022 17:10
@yelite yelite force-pushed the tunip-expr-associativity branch from 90b3a9c to ca9079f Compare July 28, 2022 16:23
@yelite yelite marked this pull request as ready for review July 28, 2022 16:27
This PR:

- Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as
`1 * (2 + 3)`)
- Addresses remaining feedback from previous PR apache#12112
- Reformats Python import with isort

Tracking issue: apache#11912
@junrushao junrushao force-pushed the tunip-expr-associativity branch from ca9079f to a3c7d73 Compare August 1, 2022 01:57
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@junrushao junrushao merged commit 834e998 into apache:main Aug 1, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This PR:

- Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as
`1 * (2 + 3)`)
- Addresses remaining feedback from previous PR apache#12112
- Reformats Python import with isort

Tracking issue: apache#11912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants