add support for subgraphs. #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tqchen @piiswrong could you review the code again? |
Contributor
Author
|
I tried all unit tests in tests/python/unittest and all of them work fine. |
Member
|
await approval from @piiswrong we want to merge this in so it won't block @zheng-da |
zheng-da
force-pushed
the
subgraph
branch
2 times, most recently
from
64acc33 to
dfa479e
Compare
Member
|
@tqchen It seems that CI failed because "no space left on device". Could you help with this issue? Thanks! |
Member
|
should be fixed, please rebase to trigger build again |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
* add support for subgraphs. * fix. * fix. * Fix compilation error * Fix compilation error * add comments. * update comments. * Sanity check on subgraphs when creating IndexedGraph * avoid the overhead of sanity check. * Stop using non-recursive DFS * Trigger CI * trigger CI
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
* add support for subgraphs. * fix. * fix. * Fix compilation error * Fix compilation error * add comments. * update comments. * Sanity check on subgraphs when creating IndexedGraph * avoid the overhead of sanity check. * Stop using non-recursive DFS * Trigger CI * trigger CI
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
* add support for subgraphs. * fix. * fix. * Fix compilation error * Fix compilation error * add comments. * update comments. * Sanity check on subgraphs when creating IndexedGraph * avoid the overhead of sanity check. * Stop using non-recursive DFS * Trigger CI * trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to provide a subgraph as the input of an operator and save and load a graph with subgraph nodes. The subgraph has to be disjoint with the main graph.