[Relay][Frontend][Onnx] Add RNN operation for ONNX frontend #12213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2022 14:55
Contributor
|
I'll take a look today |
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
I think it looks fine. My main concern is about the high amount of similar code between this and LSTM. Can you try a refactor to share relevant parts with each other instead of copy paste?
Also q about tests
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…2213) * Add RNN operation for ONNX frontend. * link checks * rm test_rnn_batchwise in unsupported_onnx_tests * merge similar codes to class methods * implement opset 14 and refactor test_forward * reformat verify_rnn_helper Co-authored-by: 张亦驰 <zhangyichi1@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RNN operator for ONNX frontend. Note that currently onnxruntime (<= 1.12.0) has wrong default values (all zeros) for all activations so I removed default value tests for HardSigmoid.
cc @mbrookhart @AndrewZhaoLuo