[MetaSchedule][Test] Add unittests for GRP #12246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
approved these changes
Jul 31, 2022
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
LGTM! Haven't seen new unit tests for long time 😆
| T.reads(conv2d_nhwc_global[v0, v1, v2, v3]) | ||
| T.writes(conv2d_nhwc[v0, v1, v2, v3]) | ||
| conv2d_nhwc[v0, v1, v2, v3] = conv2d_nhwc_global[v0, v1, v2, v3] | ||
| @T.prim_func |
Contributor
There was a problem hiding this comment.
Just out of curiosity, do we need blank lines in between 👀?
Member
Author
There was a problem hiding this comment.
it's probably not a problem here, but if those functions are in global scope, i would prefer adding blank lines in-between
Member
Author
|
@MasterJH5574 Yeah I've been planning to cover the search space of common workloads so that it will be less likely to go wrong when mainline keeps updating (it happened multiple times previously which was quite painful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @zxybazh @MasterJH5574