[TIR] Add DeclBuffer IR node and functors #12300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Hzfengsy,
Lunderberg,
junrushao,
tqchen and
wrongtest-intellif
4 tasks
Member
|
CC @cyx-6 please review for potential TVMScript syntactic/semantic change :-) |
Contributor
LGTM. New parser is compatible with this change, and will be updated soon. |
Hzfengsy
approved these changes
Aug 5, 2022
junrushao
approved these changes
Aug 5, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Overall LGTM. A quick question: after this change, the parser will treat T.decl_buffer as an IR construct instead of an intrinsic that declares a buffer - is my understanding correct?
Member
Author
|
yes. |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [TIR] Add DeclBuffer node * [TIR] Add IR functors for DeclBuffer * [TVMScript] Add printer and parser for DeclBuffer * Update printer * Update printer * Add test case * lint * fix
quic-sanirudh
added a commit
to quic-sanirudh/tvm
that referenced
this pull request
Feb 23, 2023
`DeclBufferNode` was added recently in apache#12300, but support to traverse it in codegen_llvm was not added. Since this just stmt just declares a new buffer for a body of TIR, we just need to traverse the body to properly generate code for LLVM.
kparzysz-quic
pushed a commit
that referenced
this pull request
Feb 23, 2023
`DeclBufferNode` was added recently in #12300, but support to traverse it in codegen_llvm was not added. Since this just stmt just declares a new buffer for a body of TIR, we just need to traverse the body to properly generate code for LLVM.
yongwww
pushed a commit
to yongwww/tvm
that referenced
this pull request
Feb 27, 2023
`DeclBufferNode` was added recently in apache#12300, but support to traverse it in codegen_llvm was not added. Since this just stmt just declares a new buffer for a body of TIR, we just need to traverse the body to properly generate code for LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #11627. It added the IR node
DeclBufferNode, IR functors and TVMScript printer / parser.cc @tqchen @Lunderberg @Hzfengsy @junrushao1994 @wrongtest-intellif