[TVMScript] Printer Frame #12366
Merged
[TVMScript] Printer Frame #12366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2022
junrushao
reviewed
Aug 11, 2022
Member
|
The PR looks pretty good! Let's address my nitpick and get the CI green |
junrushao
approved these changes
Aug 12, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Implement Frame for the TVMScript Unified Printer Compared to the prototype version, this: - Removes the dependency of VarTable (SymbolTable) from Frame - Adds a callback array to the Frame base class so that VarTable can add callback to clean variable when Frame goes out scope Tracking issue: apache#11912
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This PR: - Implement Frame for the TVMScript Unified Printer Compared to the prototype version, this: - Removes the dependency of VarTable (SymbolTable) from Frame - Adds a callback array to the Frame base class so that VarTable can add callback to clean variable when Frame goes out scope Tracking issue: apache#11912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Compared to the prototype version, this:
Tracking issue: #11912
cc @junrushao1994 @gbonik