[LLVM] Add "cl-opt" attribute to target_kind "llvm" #12440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 15, 2022 10:58
Add LLVMTargetInfo class that can be used to query the LLVM configuration without forcing an LLVMTarget to be created. There is no programmatic way to obtain the actual type of an LLVM option. The type is necessary to obtain the value of the option, hence it must be provided as a part of the option string. See src/target/llvm/target_kind.cc for more information about the syntax.
areusch
reviewed
Aug 18, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
thanks @kparzysz-quic ! couple questions
Contributor
Author
|
Ping. |
areusch
reviewed
Aug 22, 2022
areusch
approved these changes
Aug 22, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [LLVM] Add "cl-opt" attribute to target_kind "llvm" Add LLVMTargetInfo class that can be used to query the LLVM configuration without forcing an LLVMTarget to be created. There is no programmatic way to obtain the actual type of an LLVM option. The type is necessary to obtain the value of the option, hence it must be provided as a part of the option string. See src/target/llvm/target_kind.cc for more information about the syntax. * Fix lowercasing of bool value string * Use std::optional instead of std::pair<..., bool> * Treat malformed options as fatal errors * Fix linter * More unit tests for option parsing, have one case per test * Remove "option ignored" from fatal error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LLVMTargetInfoclass that can be used to query the LLVM configuration without forcing anLLVMTargetto be created.There is no programmatic way to obtain the actual type of an LLVM option. The type is necessary to obtain the value of the option, hence it must be provided as a part of the option string.
See
src/target/llvm/target_kind.ccfor more information about the syntax.