Skip to content

Conversation

@gayatripk1
Copy link
Contributor

@gayatripk1 gayatripk1 commented Aug 19, 2022

This PR adds implementation for quantized depthwise convolution op for hexagon. The quantization method uses fixed-point number to replace floating point instructions.

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

cc @mehrdadh

@github-actions github-actions bot requested a review from mehrdadh August 19, 2022 09:12
@gayatripk1 gayatripk1 force-pushed the gayatripk1/quant-dwconv branch from 0b88533 to 024d856 Compare August 30, 2022 19:33
@gayatripk1 gayatripk1 force-pushed the gayatripk1/quant-dwconv branch from 225c601 to 2af97a3 Compare September 8, 2022 10:01
@gayatripk1 gayatripk1 force-pushed the gayatripk1/quant-dwconv branch from c872acf to 55c7822 Compare October 17, 2022 11:10
@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 18, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@gayatripk1 gayatripk1 force-pushed the gayatripk1/quant-dwconv branch from e68d590 to 6690e8a Compare October 19, 2022 00:46
@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@mehrdadh
Copy link
Member

@gayatripk1 please update the PR description

@gayatripk1
Copy link
Contributor Author

@gayatripk1 please update the PR description

Done.

E-Bias+x+1 < 15
E-Bias+x+1 <= 14
Max x will make E-Bias+x+1 = 14
x = 13 - E + Bias
Copy link
Member

@masahi masahi Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ibsidorenko - I'm curious how the requantize operation done in QC "slice ops" (such as this PR) compares to the one done by QNN canonicalization.

@masahi masahi merged commit b9e5c02 into apache:main Oct 28, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
* [TOPI][Hexagon] Implement quantized depthwise conv2d

* Fix lint errors

* Fix lint error

* Fix lint errors
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* [TOPI][Hexagon] Implement quantized depthwise conv2d

* Fix lint errors

* Fix lint error

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants