[TIR][Schedule] Support for specific consumer block targeting in cache_read #12505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
changed the title
Contributor
Author
|
@vinx13, @tkonolige, @Hzfengsy can you guys give this PR a look? |
vinx13
reviewed
Aug 19, 2022
vinx13
approved these changes
Aug 22, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…e_read (apache#12505) * Add optional consumer blocks to cache_read. * remove comments * Fully functional * Add test for consumer targetting. * Formatting. * Add missing parameter comment. * Fix comments * Simplify type of consumer_blocks in python. * Change how consumer_blocks is printed in python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in tir, using
cache_readwill rewrite all consumer blocks of the specified buffer in the current scope. However, there may be cases where we want to apply that transformation only to a subset of consumer blocks. In the te version of cache_read, this is explicitly specified through a list ofconsumer_blocks. This PR extends the tir version ofcache_readwith an optionalconsumer_blocksargument. When provided, only blocks listed inconsumer_blockswill be rewritten. If not provided, the current behavior ofcache_readremains the same.cc @junrushao1994