[TIR][CompactBufferAllocation] Improve upperbound estimation of buffer compaction #12527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Hzfengsy,
junrushao and
spectrometerHBH
wrongtest-intellif
force-pushed
the
improve_upperbound_estimation_of_buffer_compaction
branch
from
d76c1eb to
41a1615
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…r compaction (apache#12527) Hi, this change wants to add some minor updation to region estimator used by buffer compaction: - Add and clearify among `EstimateRegionStrictBound`, `EstimateRegionLowerBound` and `EstimateRegionUpperBound` Originally we have `EstimateRegionLowerBound`, actually it implements strict bound estimation IMO. Now add `upper` and `strict` version for where we actually want them. - When estimating upperbounds (eg. in buffer compaction), try estimate each dimension independently when they are dependent accesses where `EstimateRegionLowerBound` is expected to fail. Eg, `A[i, i], 3 < i < 16` fails via `EstimateRegionLowerBound` who check indices be independent. But we can still try best to invoke strict bound analysis on each dimension individually. - If range->extent == 1 for `EvalSet(range, dom)`, invoke `EvalSet(range->min, dom)` instead. Eg, `EvalSet([k*k, k*k+1), dom_k)` results to [-inf, +inf] due to current algorithm limitation but `EvalSet(k*k, dom_k)` results to a range which makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this change wants to add some minor updation to region estimator used by buffer compaction:
Add and clearify among
EstimateRegionStrictBound,EstimateRegionLowerBoundandEstimateRegionUpperBoundOriginally we have
EstimateRegionLowerBound, actually it implements strict bound estimation IMO. Now addupperandstrictversion for where we actually want them.When estimating upperbounds (eg. in buffer compaction), try estimate each dimension independently when they are dependent accesses where
EstimateRegionLowerBoundis expected to fail.Eg,
A[i, i], 3 < i < 16fails viaEstimateRegionLowerBoundwho check indices be independent. But we can still try best to invoke strict bound analysis on each dimension individually.If range->extent == 1 for
EvalSet(range, dom), invokeEvalSet(range->min, dom)instead.Eg,
EvalSet([k*k, k*k+1), dom_k)results to [-inf, +inf] due to current algorithm limitation butEvalSet(k*k, dom_k)results to a range which makes more sense.cc @Hzfengsy @junrushao @junrushao1994 @spectrometerHBH