-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[ETHOSN] Improve inferring new shape of the Reshape operator #12594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETHOSN] Improve inferring new shape of the Reshape operator #12594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @NicolaLancellotti. Presumably due to this change: https://github.com/apache/tvm/pull/12594/files#diff-0cc1c5de01e0cebda9c447e34492ede3ae3121a9b6e11296218ecae47b299c68L329, the CI is failing on a network test. I also left a small comment below that you might as well add in at the same time :) Otherwise LGTM!
ab89ad8 to
73d05df
Compare
|
After reading apache/tvm-rfcs#88 I think we should quickly update the PR body to be more specific about the fix, WDYT? (No need to push a new commit, I can change the commit message so it matches the PR) |
It is good to me to update the PR body. |
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks @NicolaLancellotti! |
…12594) Fixes the case when reshape is > 4 dims. While this cannot be offloaded to the NPU, the check was previously producing an error preventing further compilation. The correct behavior is to ensure the check returns False and not offload the reshape.
Fixes the case when reshape is > 4 dims. While this cannot be offloaded to the NPU, the check was previously producing an error preventing further compilation. The correct behavior is to ensure the check returns False and not offload the reshape.
cc @lhutton1