Skip to content

Conversation

@NicolaLancellotti
Copy link
Contributor

@NicolaLancellotti NicolaLancellotti commented Aug 25, 2022

Fixes the case when reshape is > 4 dims. While this cannot be offloaded to the NPU, the check was previously producing an error preventing further compilation. The correct behavior is to ensure the check returns False and not offload the reshape.

cc @lhutton1

@NicolaLancellotti
Copy link
Contributor Author

@lhutton1 @leandron

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @NicolaLancellotti. Presumably due to this change: https://github.com/apache/tvm/pull/12594/files#diff-0cc1c5de01e0cebda9c447e34492ede3ae3121a9b6e11296218ecae47b299c68L329, the CI is failing on a network test. I also left a small comment below that you might as well add in at the same time :) Otherwise LGTM!

@NicolaLancellotti NicolaLancellotti force-pushed the ethosn/reshape-infer-new-shape branch from ab89ad8 to 73d05df Compare August 30, 2022 15:24
@lhutton1
Copy link
Contributor

lhutton1 commented Aug 31, 2022

After reading apache/tvm-rfcs#88 I think we should quickly update the PR body to be more specific about the fix, WDYT? (No need to push a new commit, I can change the commit message so it matches the PR)

@NicolaLancellotti
Copy link
Contributor Author

After reading apache/tvm-rfcs#88 I think we should quickly update the PR body to be more specific about the fix, WDYT? (No need to push a new commit, I can change the commit message so it matches the PR)

It is good to me to update the PR body.

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhutton1 lhutton1 merged commit acbbd9f into apache:main Aug 31, 2022
@lhutton1
Copy link
Contributor

Thanks @NicolaLancellotti!

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…12594)

Fixes the case when reshape is > 4 dims. While this cannot be offloaded to the NPU, the check was previously producing an error preventing further compilation. The correct behavior is to ensure the check returns False and not offload the reshape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants