Skip to content

[Bugfix][CMake] Update the minimum CMake version to 3.18 #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driazati merged 2 commits into from
Sep 29, 2022
Merged

[Bugfix][CMake] Update the minimum CMake version to 3.18 #12682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e798a0
Update the minimum CMake version
slyubomirsky Sep 2, 2022
1c3f9f0
Add note about CMake version in installation docs
slyubomirsky Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.2)
cmake_minimum_required(VERSION 3.18)
Copy link
Member

@driazati driazati Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update the requirements in install/from_source.rst to match?

Copy link
Contributor Author

@slyubomirsky slyubomirsky Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thanks

project(tvm C CXX)

# Utility functions
Expand Down
5 changes: 4 additions & 1 deletion docs/install/from_source.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ The minimal building requirements for the ``TVM`` libraries are:
- Clang 5.0
- Apple Clang 9.3
- Visual Studio 2019 (v16.7)
- CMake 3.10 or higher
- CMake 3.18 or higher
- We highly recommend to build with LLVM to enable all the features.
- If you want to use CUDA, CUDA toolkit version >= 8.0 is required. If you are upgrading from an older version, make sure you purge the older version and reboot after installation.
- On macOS, you may want to install `Homebrew <https://brew.sh>`_ to easily install and manage dependencies.
Expand All @@ -78,6 +78,9 @@ linux operating systems, execute (in a terminal):
sudo apt-get update
sudo apt-get install -y python3 python3-dev python3-setuptools gcc libtinfo-dev zlib1g-dev build-essential cmake libedit-dev libxml2-dev


Note that the version of CMake on apt may not be sufficiently up to date; it may be necessary to install it directly from `Kitware's third-party APT repository <https://apt.kitware.com/>`_.

Use Homebrew to install the required dependencies for macOS running either the Intel or M1 processors. You must follow the post-installation steps specified by
Homebrew to ensure the dependencies are correctly installed and configured:

Expand Down