[ci][docker] Always build cmake from source #12774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix some version drift in the current cmake versions in the Docker containers (currently running all of 3.10, 3.16, 3.18, and 3.20)
Contributor
areusch
reviewed
Sep 15, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
what about using the cmake ppa? https://apt.kitware.com/
Contributor
|
discussed offline, and one benefit to this method is uniform cmake version. my prototype does have the disadvantage of installing different cmake versions on different platforms; that might be more interesting if they were also the default version of cmake installed via |
areusch
approved these changes
Sep 15, 2022
1 task
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This should fix some version drift in the current cmake versions in the Docker containers (currently running all of 3.10, 3.16, 3.18, and 3.20) Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some version drift in the current cmake versions in the
Docker containers (currently running all of 3.10, 3.16, 3.18, and 3.20)
cc @Mousius @areusch @gigiblender