[Hexagon] [runtime] Protect access to global HexagonBufferManager map #12807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetsc
changed the title
janetsc
changed the title
adstraw
approved these changes
Sep 16, 2022
Contributor
adstraw
left a comment
adstraw
left a comment
There was a problem hiding this comment.
LGTM; great work debugging by the team.
Contributor
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…apache#12807) * Protect access to global buffer manager map * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each thread has its own thread local storage for workspace and pool objects. But those perform allocations from a global HexagonBufferManager. We found a case where the map was not getting updated during AllocWorkspace, which then later caused FreeWorkspace to fail.
Added a mutex to protect all access to the map.
cc: @nverke @JosephTheOctonaut @adstraw @supersat
cc @areusch @mehrdadh