Skip to content

Conversation

@cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Sep 16, 2022

This PR introduces remaining IRBuilder methods for Block.

Co-authored-by: yongwww yongcale@gmail.com

@junrushao
Copy link
Member

to fix mypy complaints, you may use:

     def __enter__(self) -> "IRBuilderFrame":
-        _ffi_api.IRBuilderFrameEnter(self)  # pylint: disable=no-member # type: ignore
+        _ffi_api.IRBuilderFrameEnter(self)  # type: ignore  # pylint: disable=no-member
         return self

     def __exit__(self, ptype, value, trace) -> None:  # pylint: disable=unused-argument
-        _ffi_api.IRBuilderFrameExit(self)  # pylint: disable=no-member # type: ignore
+        _ffi_api.IRBuilderFrameExit(self)  # type: ignore # pylint: disable=no-member

cyx-6 and others added 2 commits September 16, 2022 14:46
This PR introduces remaining IRBuilder methods for `Block`.

Co-authored-by: yongwww <yongcale@gmail.com>
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao junrushao merged commit 41b65a3 into apache:main Sep 17, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This PR introduces remaining IRBuilder methods for `Block`.

Co-authored-by: yongwww <yongcale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants