[TIR][Transform] Remove num_unpacked_args from MakePackedAPI #12892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other than a single unit test, there are no usages of this parameter in TVM, and it significantly complicates the logic of `MakePackedAPI`. Similar functionality can be had by using `MakeUnpackedAPI` instead.
Member
|
Thanks for doing this @Lunderberg, I've often wondered what this was for 🤔 |
Contributor
Author
Mousius
requested changes
Sep 26, 2022
Accidentally left an occurrence of `num_unpacked_params` in the Python call.
Lunderberg
force-pushed
the
remove_num_unpacked_args
branch
from
5f2db06 to
fa08230
Compare
Mousius
approved these changes
Sep 27, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…12892) Other than a single unit test, there are no usages of this parameter in TVM, and it significantly complicates the logic of `MakePackedAPI`. Similar functionality can be had by using `MakeUnpackedAPI` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than a single unit test, there are no usages of this parameter in TVM, and it significantly complicates the logic of
MakePackedAPI. Similar functionality can be had by usingMakeUnpackedAPIinstead.