-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Hexagon] vrmpy tensorization for e2e compilation of int8 models #12911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e9d1cea
[Hexagon] Support vrmpy tensorization for conv2d and dense schedules
masahi 2cd5ae8
update
masahi d8b6be7
clean up
masahi 21bcd55
migrate tests to test_launcher.py
masahi 39b17f6
remove vrmpy test files
masahi e95daae
use generic int8 conv2d schedule
masahi cabe37c
clean up
masahi d253153
doc update
masahi 17bde45
pylint fix
masahi 2537411
parametrize dtype in test
masahi 978158d
doc update
masahi 4ad3e63
add missing paralleization for dense
masahi 849ed3c
more pylint
masahi 2088965
fixed for fp32 dense
masahi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # pylint: disable=invalid-name,unused-variable,unused-argument,no-member | ||
| """Conv2d alter op functions for Hexagon""" | ||
|
|
||
| from tvm import relay | ||
| from ..utils import get_const_tuple | ||
| from .. import nn | ||
| from ..nn import conv2d_alter_layout | ||
| from ..generic.conv2d import conv2d_alter_int8_common | ||
|
|
||
|
|
||
| @conv2d_alter_layout.register("hexagon") | ||
| def _alter_conv2d_layout(attrs, inputs, tinfos, out_type): | ||
| """Convert nn.conv2d into nn.contrib_conv2d_nchwc if vrmpy is applicable.""" | ||
| new_attrs = {k: attrs[k] for k in attrs.keys()} | ||
|
|
||
| data_layout = attrs["data_layout"] | ||
| kernel_layout = attrs["kernel_layout"] | ||
| data_tensor, kernel_tensor = tinfos | ||
| out_channel, in_channel, _, _ = get_const_tuple(kernel_tensor.shape) | ||
|
|
||
| if ( | ||
| "int8" in data_tensor.dtype | ||
| and "int8" in kernel_tensor.dtype | ||
| and out_channel % 32 == 0 | ||
| and in_channel % 4 == 0 | ||
| and data_layout == "NCHW" | ||
| and kernel_layout == "OIHW" | ||
| ): | ||
| out_channel, in_channel, _, _ = get_const_tuple(kernel_tensor.shape) | ||
|
|
||
| n_elems = 4 | ||
| oc_bn = 32 | ||
| ic_bn = min(in_channel, 32) | ||
|
|
||
| new_attrs = {k: attrs[k] for k in attrs.keys()} | ||
|
|
||
| new_attrs["channels"] = out_channel | ||
| new_attrs["data_layout"] = "NCHW%dc" % ic_bn | ||
| new_attrs["kernel_layout"] = "OIHW{:n}i{:n}o{:n}i".format(ic_bn // n_elems, oc_bn, n_elems) | ||
| new_attrs["out_layout"] = "NCHW%dc" % oc_bn | ||
|
|
||
| return relay.nn.contrib_conv2d_nchwc(*inputs, **new_attrs) | ||
|
|
||
| return None | ||
|
|
||
|
|
||
| @nn.conv2d_legalize.register("hexagon") | ||
| def _conv2d_legalize(attrs, inputs, arg_types): | ||
| """Legalize conv2d op for vrmpy tensorization. | ||
|
|
||
| If the inputs are signed or unsigned int8, the input and output channels are padded to be | ||
| a multiple of 4 and 32 respectively. | ||
|
|
||
| If the input data types are (int8, int8), they are converted to (uint8, int8) and | ||
| the vector-by-vector variant of vrmpy is applied. | ||
| If the input data types are (uint8, uint8), the more efficient vector-by-scalar variant of vrmpy | ||
| is applied. | ||
|
|
||
| Unlike the nn.dense case (see dense_alter_op.py), we do not convert (uint8, int8) to | ||
| (uint8, uint8). That would introduce another convolution by a constant (128 or 1) filter, | ||
| to compensate for the dtype legalization. In the nn.dense case, such compensation factor is | ||
| just a sum over the K axis. | ||
| """ | ||
| data_layout = attrs["data_layout"] | ||
| kernel_layout = attrs["kernel_layout"] | ||
|
|
||
| output_tensor = arg_types[2] | ||
|
|
||
| data, kernel = inputs | ||
|
|
||
| if data_layout != "NCHW" or kernel_layout != "OIHW": | ||
| return None | ||
|
|
||
| data_tensor, kernel_tensor = arg_types[0], arg_types[1] | ||
|
|
||
| if "int8" in data_tensor.dtype and "int8" in data_tensor.dtype: | ||
| output_tensor = arg_types[2] | ||
| data, kernel = inputs | ||
| desired_data_dtype = "uint8" | ||
| in_channel_vector_length = 4 | ||
| out_channel_vector_length = 32 | ||
|
|
||
| return conv2d_alter_int8_common( | ||
| data, | ||
| data_tensor, | ||
| kernel, | ||
| kernel_tensor, | ||
| output_tensor, | ||
| attrs, | ||
| desired_data_dtype, | ||
| in_channel_vector_length, | ||
| out_channel_vector_length, | ||
| ) | ||
|
|
||
| return None | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ibsidorenko @tkonolige @nverke on this. We can convert u8 * s8 convolution to u8 * u8 like below
Here,
X_u8 * 128is a convolution ofX_u8by a constant filter. We can factor out 128 to end up with a filter where all elements are 1. So what we need is a windowed sum, or "sum pooling" op - without it, I think we need to do a full blown convolution. This is why I don't use legalization for conv2d. Let me know if you have better idea.