[TIR][MetaSchedule] Add regression test for layout_rewrite extent=1 #12916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a regression test for using the `layout_rewrite` post-proc on a buffer with an extent of one in at least one dimension, issue apache#12852. This bug was resolved as part of the refactor in apache#12904, but didn't have a regression test at that point.
zxybazh
approved these changes
Sep 27, 2022
Contributor
Author
|
Ooh, the commented "segfaults" case was during testing, but I didn't return to it. There was a segfault that occurred when attempting to use a layout-postproc on a non-schedulable TIR primfunc. I should either remove it, or identify/remove the cause of the segfaults. |
Contributor
Author
|
The segfault now raises an exception instead, and the test case validates it. |
Member
|
@vinx13 Would you like to take a look and merge it if everything looks good? |
vinx13
approved these changes
Sep 28, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…pache#12916) * [TIR][MetaSchedule] Add regression test for layout_rewrite extent=1 Adds a regression test for using the `layout_rewrite` post-proc on a buffer with an extent of one in at least one dimension, issue apache#12852. This bug was resolved as part of the refactor in apache#12904, but didn't have a regression test at that point. * Identified segfault and added test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a regression test for using the
layout_rewritepost-proc on a buffer with an extent of one in at least one dimension, issue #12852. This bug was resolved as part of the refactor in #12904, but didn't have a regression test at that point.CC @vinx13 @junrushao @zxybazh