[Hexagon] [runtime] Support VTCM alignments of 128 or 2k #12999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
approved these changes
Oct 11, 2022
nverke
approved these changes
Oct 11, 2022
Contributor
nverke
left a comment
nverke
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding those tests even though I didnt publish the comment haha!
Contributor
Author
|
@tvm-bot rerun |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
In order to simplify the dynamic VTCM memory pool, it will support the following alignments: 2k boundaries, allocated from the front of the pool in the smallest open spot possible. 128 byte boundaries, allocated from the end of the pool. Made this support explicit, modified test to hit these boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the dynamic VTCM memory pool, it will support the following alignments:
2k boundaries, allocated from the front of the pool in the smallest open spot possible.
128 byte boundaries, allocated from the end of the pool.
Made this support explicit, modified test to hit these boundaries.
cc: @kparzysz-quic, @supersat, @csullivan