[ROOFLINE] Add support for different dtypes #13003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will take a look today |
tkonolige
force-pushed
the
roofline_dtype
branch
from
e920015 to
cf3b3aa
Compare
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
Thanks @tkonolige , some comments. I do have concerns about one part of the refactor.
added 4 commits
October 13, 2022 16:32
Support different dtypes in roofline analysis. Only x86 support for now, but the interface is there to add support on cuda.
tkonolige
force-pushed
the
roofline_dtype
branch
from
ff2d4f0 to
96e31bd
Compare
AndrewZhaoLuo
approved these changes
Oct 14, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
* [ROOFLINE] Add support for different dtypes Support different dtypes in roofline analysis. Only x86 support for now, but the interface is there to add support on cuda. * whoops * add div, mad*2 to flops count * remove skips (from bad rebase) * match features by name format
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [ROOFLINE] Add support for different dtypes Support different dtypes in roofline analysis. Only x86 support for now, but the interface is there to add support on cuda. * whoops * add div, mad*2 to flops count * remove skips (from bad rebase) * match features by name format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support different dtypes in roofline analysis. Only x86 support for now, but the interface is there to add support on cuda.
@AndrewZhaoLuo