[TIR] Refactor NarrowDataType into DataTypeLegalizer #13049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
github-actions
bot
requested review from
Hzfengsy,
junrushao and
wrongtest-intellif
spectrometerHBH
approved these changes
Oct 14, 2022
Hzfengsy
approved these changes
Oct 14, 2022
Comment on lines
+21
to
+22
| * \file data_type_rewriter.cc | ||
| * \brief Rewrite the data type of expressions. |
Contributor
There was a problem hiding this comment.
Should we update the filename to data_type_legalizer.cc or keep it as “rewriter”?
| @@ -0,0 +1,140 @@ | |||
| /* | |||
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataTypeLegalizercan be used for more general purpose. This PR extracts the data type legalizing logic fromNarrowDataTypeinto a separate base class. There are no functional changes.cc @Hzfengsy @junrushao @wrongtest-intellif