[TIR][FIX] Fix crash when using 'if' without 'else' in TVMScript #13054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
shingjan
suggested changes
Oct 12, 2022
shingjan
left a comment
shingjan
left a comment
There was a problem hiding this comment.
Thanks for sending this! Looks fine to me. Would that be possible that some tests can be added to this PR so we will know if future changes will break this?
WuSiYu
force-pushed
the
main-fix-tvmscript-if-without-else
branch
from
13ff8eb to
0127232
Compare
Hzfengsy
approved these changes
Oct 13, 2022
Contributor
Author
Yes, a test has been added in test_tir_analysis_estimate_tir_flops.py |
WuSiYu
force-pushed
the
main-fix-tvmscript-if-without-else
branch
from
0127232 to
5370454
Compare
Contributor
Author
|
@tvm-bot rerun |
WuSiYu
force-pushed
the
main-fix-tvmscript-if-without-else
branch
from
5370454 to
b98a87c
Compare
Contributor
Author
|
I am not sure but it seem's like the CI is failed by the other ramdom reason, should I continue to try to rerun it? |
This commit fix the tvm's crash during TVMScript's auto-tune when having a 'if' statement which doesn't have a 'else' part. It's cause in tvm's tir processing (tvm.tir.analysis.estimate_flops), in VisitStmt_() for IfThenElseNode it trying to visit the 'else' part whether it is exist. So in this commit, an if logic is added in VisitStmt_() for IfThenElseNode, it will not visit the 'else' part if it is not exist.
WuSiYu
force-pushed
the
main-fix-tvmscript-if-without-else
branch
from
b98a87c to
5f95c0f
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
…che#13054) This commit fix the tvm's crash during TVMScript's auto-tune when having a 'if' statement which doesn't have a 'else' part. It's cause in tvm's tir processing (tvm.tir.analysis.estimate_flops), in VisitStmt_() for IfThenElseNode it trying to visit the 'else' part whether it is exist. So in this commit, an if logic is added in VisitStmt_() for IfThenElseNode, it will not visit the 'else' part if it is not exist. Co-authored-by: SiYu Wu <wusiyu@buaa.edu.cn>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…che#13054) This commit fix the tvm's crash during TVMScript's auto-tune when having a 'if' statement which doesn't have a 'else' part. It's cause in tvm's tir processing (tvm.tir.analysis.estimate_flops), in VisitStmt_() for IfThenElseNode it trying to visit the 'else' part whether it is exist. So in this commit, an if logic is added in VisitStmt_() for IfThenElseNode, it will not visit the 'else' part if it is not exist. Co-authored-by: SiYu Wu <wusiyu@buaa.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the tvm's crash during auto-tune when having a 'if' statement which doesn't have a 'else' part in TVMScript.
It's cause in tvm's tir processing, in
VisitStmt_()for IfThenElseNode its trying to visit the 'else' part (in TVMScript) whether it is exist.So in this commit, an if logic is added in
VisitStmt_()for IfThenElseNode, it will not visit the 'else' part if it is not exist.