Skip to content

Conversation

@cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Oct 15, 2022

This PR introduces Evaluator, core parser, var table as part of #12442

Co-authored-by: yongwww yongcale@gmail.com

This PR introduces Evaluator, core parser, var table as part of apache#12442

Co-authored-by: yongwww <yongcale@gmail.com>
@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 15, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: tvmscript See #10317 for details
  • Built docs for commit 08d461a can be found here.

Generated by tvm-bot

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cyx-6 for the hard work!

@MasterJH5574 MasterJH5574 merged commit 9299a29 into apache:main Oct 16, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
* [TVMScript] Evaluator, core parser, var table

This PR introduces Evaluator, core parser, var table as part of apache#12442

Co-authored-by: yongwww <yongcale@gmail.com>

* add module doc string

* apply code review suggestion

Co-authored-by: yongwww <yongcale@gmail.com>
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* [TVMScript] Evaluator, core parser, var table

This PR introduces Evaluator, core parser, var table as part of apache#12442

Co-authored-by: yongwww <yongcale@gmail.com>

* add module doc string

* apply code review suggestion

Co-authored-by: yongwww <yongcale@gmail.com>
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up change is required, following what was discussed in https://discuss.tvm.apache.org/t/reminder-of-our-code-review-guidelines/14388

In this case it is not by the face that it was merged too early, but probably because of the comments that might be confusing to some users.

@tqchen
Copy link
Member

tqchen commented Mar 21, 2023

Thanks for the suggestion.

This is an API used by TVMScript internally, and the particular remark is only making an example and such example won't add confusions to the use of the API. Nor will it break any other modules in tvm.

If any one of the current TVMScript maintainers feels it is out of place. I think they should be able to come and fix it. But my take is that they are not, as such I would hope to appreciate the volunteering time effort of the module maintainers and let them make the call.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants