-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TVMScript] Evaluator, core parser, var table #13088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR introduces Evaluator, core parser, var table as part of apache#12442 Co-authored-by: yongwww <yongcale@gmail.com>
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
MasterJH5574
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @cyx-6 for the hard work!
* [TVMScript] Evaluator, core parser, var table This PR introduces Evaluator, core parser, var table as part of apache#12442 Co-authored-by: yongwww <yongcale@gmail.com> * add module doc string * apply code review suggestion Co-authored-by: yongwww <yongcale@gmail.com>
* [TVMScript] Evaluator, core parser, var table This PR introduces Evaluator, core parser, var table as part of apache#12442 Co-authored-by: yongwww <yongcale@gmail.com> * add module doc string * apply code review suggestion Co-authored-by: yongwww <yongcale@gmail.com>
leandron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A follow-up change is required, following what was discussed in https://discuss.tvm.apache.org/t/reminder-of-our-code-review-guidelines/14388
In this case it is not by the face that it was merged too early, but probably because of the comments that might be confusing to some users.
|
Thanks for the suggestion. This is an API used by TVMScript internally, and the particular remark is only making an example and such example won't add confusions to the use of the API. Nor will it break any other modules in tvm. If any one of the current TVMScript maintainers feels it is out of place. I think they should be able to come and fix it. But my take is that they are not, as such I would hope to appreciate the volunteering time effort of the module maintainers and let them make the call. Thank you |
This PR introduces Evaluator, core parser, var table as part of #12442
Co-authored-by: yongwww yongcale@gmail.com