Skip to content

Conversation

@masahi
Copy link
Member

@masahi masahi commented Oct 17, 2022

A follow up to #13050, also builds on #13001. This PR enables the functionality in #12706 without changing the existing StructuralEqual/Hash.

A question for discussion: Should this be the default ModuleEquality used by MS? It has no effect for the link-params = False case, and it simplifies the MS tuning API usage for the link-params = True case (Hexagon etc).

cc @junrushao @zxybazh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 17, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao junrushao merged commit 34c43d4 into apache:main Oct 17, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
…ng NDArray raw data (apache#13091)

A follow up to apache#13050, also builds on apache#13001. This PR enables the functionality in apache#12706 without changing the existing `StructuralEqual/Hash`.

A question for discussion: Should this be the default ModuleEquality used by MS? It has no effect for the `link-params = False` case, and it simplifies the MS tuning API usage for the `link-params = True` case (Hexagon etc).
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…ng NDArray raw data (apache#13091)

A follow up to apache#13050, also builds on apache#13001. This PR enables the functionality in apache#12706 without changing the existing `StructuralEqual/Hash`.

A question for discussion: Should this be the default ModuleEquality used by MS? It has no effect for the `link-params = False` case, and it simplifies the MS tuning API usage for the `link-params = True` case (Hexagon etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants