Skip stride check if shape is 1 in IsContiguous #13121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Member
|
Hi Lite, can you please fix the linting issue? |
yelite
force-pushed
the
fix-ndarray-contiguous-check
branch
from
6ae6202 to
64d3843
Compare
Skip stride check if shape[k] is 1, where the dimension is contiguous regardless of the value of stride. For example, PyTorch will normalize stride to 1 if shape is 1.
yelite
force-pushed
the
fix-ndarray-contiguous-check
branch
from
64d3843 to
89723a3
Compare
Contributor
Author
|
I fixed lint and added few unit tests |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
Skip checking stride if shape is 1 in IsContiguous Skip stride check if shape[k] is 1, where the dimension is contiguous regardless of the value of stride. For example, PyTorch will normalize stride to 1 if shape is 1.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Skip checking stride if shape is 1 in IsContiguous Skip stride check if shape[k] is 1, where the dimension is contiguous regardless of the value of stride. For example, PyTorch will normalize stride to 1 if shape is 1.
ghost
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 4, 2023
Skip checking stride if shape is 1 in IsContiguous Skip stride check if shape[k] is 1, where the dimension is contiguous regardless of the value of stride. For example, PyTorch will normalize stride to 1 if shape is 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip stride check if shape[k] is 1, where the dimension is contiguous regardless of the value of stride.
For example, PyTorch will normalize stride to 1 if shape is 1.
Related: pytorch/pytorch@ec42ee0
cc @junrushao @zxybazh