Skip to content

Conversation

@zxybazh
Copy link
Member

@zxybazh zxybazh commented Oct 19, 2022

Previous change #12895 inherited this test of lowering from relay which can be used for lowering test but missed the functionality of detecting argument order change. This PR restores the test to use a customized verification database to detect changes in TE to PrimFunc lowering, making sure the order of argument doesn't change.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 19, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@zxybazh zxybazh marked this pull request as ready for review October 19, 2022 00:32
@zxybazh
Copy link
Member Author

zxybazh commented Oct 19, 2022

CC @junrushao @vinx13

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@vinx13 vinx13 merged commit 842f842 into apache:main Oct 19, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants