Skip to content

Conversation

@zhyncs
Copy link
Contributor

@zhyncs zhyncs commented Oct 19, 2022

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 19, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for exposing this @zhyncs, overall LGTM, just had one small nitpick and looks like linting issues need addressing

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 19, 2022

cc @lhutton1 @Mousius @gromero

@lhutton1
Copy link
Contributor

Thanks @zhyncs for the update. Apologies for missing this before, would it also be possible to add a test for this case in https://github.com/apache/tvm/blob/main/tests/python/driver/tvmc/test_compiler.py?

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 19, 2022

The i386 compilation failure was caused by the git fetch error. How can I trigger a new one tvm-ci/pr-head? @lhutton1 @Mousius @gromero

@lhutton1
Copy link
Contributor

@tvm-bot rerun

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 19, 2022

@tvm-bot rerun

It seems that it doesn't work.

@lhutton1
Copy link
Contributor

Hmmm seems like it didn't work for some reason, could you try a git commit --amend then a force push from your local branch?

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 19, 2022

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/520
It seems that the CI system is not stable and so slow.
image
May I trigger the failed docs: GPU separately without the whole process? @lhutton1 @Mousius @gromero

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 19, 2022

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/518
And the unittest: CPU failed with the Upload JUnits to S3 error.
image

@github-actions github-actions bot requested a review from leandron October 19, 2022 19:09
@driazati
Copy link
Member

sorry the CI error there is a bit confusing (and you got a bit unlucky with the docs checkout failure, it should be fixed for subsequent runs), however there are test failures on arm: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/488#step-1582-log-1404

@areusch
Copy link
Contributor

areusch commented Oct 19, 2022

@zhyncs this looks like a github problem. they are reporting problems with their API servers, but not with git ops. might be worth retrying in a few hours in case there's something unreported going on.

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 20, 2022

sorry the CI error there is a bit confusing (and you got a bit unlucky with the docs checkout failure, it should be fixed for subsequent runs), however there are test failures on arm: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/488#step-1582-log-1404

fixed

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhyncs, LGTM!

@zhyncs
Copy link
Contributor Author

zhyncs commented Oct 20, 2022

@leandron @lhutton1 @Mousius @gromero Could you merge this PR?

@Mousius Mousius merged commit 209e77c into apache:main Oct 20, 2022
@Mousius
Copy link
Member

Mousius commented Oct 20, 2022

@zhyncs yip, I could 😸 thanks for your improvement!

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants