-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[tvmc] add instruments for PassContext #13136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for exposing this @zhyncs, overall LGTM, just had one small nitpick and looks like linting issues need addressing
|
Thanks @zhyncs for the update. Apologies for missing this before, would it also be possible to add a test for this case in https://github.com/apache/tvm/blob/main/tests/python/driver/tvmc/test_compiler.py? |
|
@tvm-bot rerun |
It seems that it doesn't work. |
|
Hmmm seems like it didn't work for some reason, could you try a git commit --amend then a force push from your local branch? |
|
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/520 |
|
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/518 |
|
sorry the CI error there is a bit confusing (and you got a bit unlucky with the docs checkout failure, it should be fixed for subsequent runs), however there are test failures on arm: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/488#step-1582-log-1404 |
|
@zhyncs this looks like a github problem. they are reporting problems with their API servers, but not with git ops. might be worth retrying in a few hours in case there's something unreported going on. |
fixed |
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhyncs, LGTM!
|
@zhyncs yip, I could 😸 thanks for your improvement! |


cc @leandron