Skip to content

[Adreno] Fix mem_scope annotations for prim funcs having several heads #13153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masahi merged 4 commits into from
Oct 24, 2022
Merged

[Adreno] Fix mem_scope annotations for prim funcs having several heads #13153

masahi merged 4 commits into from
Oct 24, 2022

Conversation

@elvin-n
Copy link
Contributor

@elvin-n elvin-n commented Oct 20, 2022

  1. decision if function can work with textures. To remove dependency on the order of traversing, we decide to markup function support textures if any input op support textures src/relay/transforms/annotate_texture_storage.cc
  2. fix of injective schedules for non blocking case for performance improvements (python/tvm/topi/adreno/utils.py

@echuraev

@elvin-n
[Adreno] Fix mem_scope annotations for prim funcs having several heads
8a4d375 
2) fix of injective schedules for non blocking case
@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 20, 2022 •
edited
Loading

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

echuraev
echuraev reviewed Oct 20, 2022
View reviewed changes
echuraev
echuraev reviewed Oct 21, 2022
View reviewed changes
echuraev
echuraev approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@elvin-n
Copy link
Contributor Author

elvin-n commented Oct 24, 2022

@masahi could you please take a look to it?

@elvin-n
Copy link
Contributor Author

elvin-n commented Oct 24, 2022

@tvm-bot rerun

@masahi masahi merged commit 3e02ac5 into apache:main Oct 24, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
@elvin-n
[Adreno] Fix mem_scope annotations for prim funcs having several heads (
8e36a8e 
apache#13153)

* [Adreno] Fix mem_scope annotations for prim funcs having several heads

2) fix of injective schedules for non blocking case

* Address PR comments

* fix lint

* Modify comment
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@elvin-n @xinetzone
[Adreno] Fix mem_scope annotations for prim funcs having several heads (
4e6b1cc 
apache#13153)

* [Adreno] Fix mem_scope annotations for prim funcs having several heads

2) fix of injective schedules for non blocking case

* Address PR comments

* fix lint

* Modify comment
@leandron leandron mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahi masahi masahi approved these changes

@echuraev echuraev echuraev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elvin-n @tvm-bot @masahi @echuraev