[Hexagon] Add power manager #13162
Merged
[Hexagon] Add power manager #13162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Contributor
Author
|
cc @janetsc |
janetsc
approved these changes
Oct 21, 2022
Contributor
janetsc
left a comment
janetsc
left a comment
There was a problem hiding this comment.
Looks good - just one quick question about HVX power!
csullivan
approved these changes
Oct 21, 2022
| int result = api_call; \ | ||
| if (result != 0) { \ | ||
| HEXAGON_PRINT(ERROR, "ERROR: " #api_call " failed with error %d.", result); \ | ||
| abort(); \ |
Contributor
There was a problem hiding this comment.
nit: Maybe LogFatal instead
Contributor
Author
There was a problem hiding this comment.
Will address this in a future PR
janetsc
pushed a commit
to janetsc/tvm
that referenced
this pull request
Oct 21, 2022
This PR adds a new class, HexagonPowerManager, which interfaces with the HAP_power API to request maximum performance. * Add Hexagon Power Manager * Remove HexagonPowerManager::LogPowerConfig * Delete HexagonPowerManager in ReleaseResources * Hexagon power manager must be destroyed after the thread manager
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
This PR adds a new class, HexagonPowerManager, which interfaces with the HAP_power API to request maximum performance. * Add Hexagon Power Manager * Remove HexagonPowerManager::LogPowerConfig * Delete HexagonPowerManager in ReleaseResources * Hexagon power manager must be destroyed after the thread manager
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR adds a new class, HexagonPowerManager, which interfaces with the HAP_power API to request maximum performance. * Add Hexagon Power Manager * Remove HexagonPowerManager::LogPowerConfig * Delete HexagonPowerManager in ReleaseResources * Hexagon power manager must be destroyed after the thread manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new class,
HexagonPowerManager, which interfaces with theHAP_powerAPI to request maximum performance.cc: @mehrdadh @csullivan @kparzysz-quic