[Hexagon] [runtime] Per-thread hardware resource management #13181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
janetsc
commented
Oct 24, 2022
janetsc
commented
Oct 24, 2022
Contributor
Author
|
@tvm-bot run |
1 similar comment
Contributor
Author
|
@tvm-bot run |
csullivan
reviewed
Oct 25, 2022
Contributor
csullivan
left a comment
csullivan
left a comment
There was a problem hiding this comment.
Great! Just a few questions
nverke
reviewed
Oct 25, 2022
nverke
reviewed
Oct 25, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
…3181) Add support to lock and unlock resources on the individual threads. Adds APIs to get a thread handle for a given resource type, and get a resource type for a given thread handle. This will aid in asynchronous support that is sending work to dedicated threads for the hardware resources. There are two steps to fully acquire a resource: reserve and lock. HTP/HVX manager objects are created on the global thread, which will reserve the resources. The lock/unlock will occur on the thread that owns a particular instance. The manager objects will be deconstructed when the thread manager is deconstructed. This will release the resources.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…3181) Add support to lock and unlock resources on the individual threads. Adds APIs to get a thread handle for a given resource type, and get a resource type for a given thread handle. This will aid in asynchronous support that is sending work to dedicated threads for the hardware resources. There are two steps to fully acquire a resource: reserve and lock. HTP/HVX manager objects are created on the global thread, which will reserve the resources. The lock/unlock will occur on the thread that owns a particular instance. The manager objects will be deconstructed when the thread manager is deconstructed. This will release the resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to lock and unlock resources on the individual threads. Adds APIs to get a thread handle for a given resource type, and get a resource type for a given thread handle. This will aid in asynchronous support that is sending work to dedicated threads for the hardware resources.
There are two steps to fully acquire a resource: reserve and lock. HTP/HVX manager objects are created on the global thread, which will reserve the resources. The lock/unlock will occur on the thread that owns a particular instance. The manager objects will be deconstructed when the thread manager is deconstructed. This will release the resources.
cc: @csullivan, @adstraw, @JosephTheOctonaut, @kparzysz-quic