Skip to content

[Relay][ONNX] Resolve proto ingestion issue for non-tensor type and add CastLike op #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driazati merged 1 commit into from
Oct 25, 2022
Merged

[Relay][ONNX] Resolve proto ingestion issue for non-tensor type and add CastLike op #13184

driazati merged 1 commit into from
Oct 25, 2022

Conversation

@ehsanmok
Copy link
Contributor

@ehsanmok ehsanmok commented Oct 24, 2022 •
edited
Loading

This PR

  • adds the missing CastLike op and
  • fixes proto injection issue for onnx node tests that include other types besides TensorType with Optional and Sequence types for the upcoming PRs
  • fixes Cast version issue.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 24, 2022 •
edited
Loading

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@ehsanmok ehsanmok mentioned this pull request Oct 25, 2022
Merged
KJlaccHoeUM9l
KJlaccHoeUM9l reviewed Oct 25, 2022
View reviewed changes
AndrewZhaoLuo
AndrewZhaoLuo approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

KJlaccHoeUM9l
KJlaccHoeUM9l approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@KJlaccHoeUM9l KJlaccHoeUM9l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ehsanmok ehsanmok changed the title [Relay][ONNX] Resolve proto injection issue for non-tensor type and add CastLike op [Relay][ONNX] Resolve proto ingestion issue for non-tensor type and add CastLike op Oct 25, 2022
@driazati driazati merged commit 7983ef2 into apache:main Oct 25, 2022
@ehsanmok ehsanmok deleted the onnx-cast branch October 25, 2022 20:46
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
@ehsanmok
[Relay][ONNX] Resolve proto ingestion issue for non-tensor type and a…
068b29e 
…dd CastLike op (apache#13184)

This PR 

* adds the missing CastLike op and 
* fixes proto injection issue for onnx node tests that include other types besides TensorType with Optional and Sequence types for the upcoming PRs
* fixes Cast version issue.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@ehsanmok @xinetzone
[Relay][ONNX] Resolve proto ingestion issue for non-tensor type and a…
3ba4615 
…dd CastLike op (apache#13184)

This PR 

* adds the missing CastLike op and 
* fixes proto injection issue for onnx node tests that include other types besides TensorType with Optional and Sequence types for the upcoming PRs
* fixes Cast version issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewZhaoLuo AndrewZhaoLuo AndrewZhaoLuo approved these changes

+1 more reviewer

@KJlaccHoeUM9l KJlaccHoeUM9l KJlaccHoeUM9l approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ehsanmok @tvm-bot @AndrewZhaoLuo @KJlaccHoeUM9l @driazati