[Hexagon]Pull and build specific LLVM sha for hexagon docker CI #13199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
|
cc @mehrdadh |
mehrdadh
requested changes
Oct 26, 2022
mehrdadh
changed the title
mehrdadh
approved these changes
Oct 28, 2022
Member
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Next step is to wait for the docker image to be build and uploaded to the tlcpackstaging. Then you need to send another PR which updated the hexagon docker image tag. That's when it actually uses the docker and run tests inside the new docker
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
…he#13199) * Pull and build specific LLVM sha for hexagon docker CI * Address comments and add default triple * Build shouldn't need lld for codegen
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…he#13199) * Pull and build specific LLVM sha for hexagon docker CI * Address comments and add default triple * Build shouldn't need lld for codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12873 needs an updated LLVM version, as noted in #12966. This PR pulls the most recent llvm patch off of main which should work with the latest tvm.