[CI] Make additional_flags parameter optional in tests/scripts/ci.py #13238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter was introduced in apache#12833, and was passed for all subcommands defined using `generate_command`. However, this broke the `ci.py lint` subcommand. This PR makes the `additional_flags` parameter to the `docker` function be optional, to avoid this breakage.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
approved these changes
Oct 31, 2022
Contributor
Author
|
@tvm-bot rerun |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
…pache#13238) This parameter was introduced in apache#12833, and was passed for all subcommands defined using `generate_command`. However, this broke the `ci.py lint` subcommand. This PR makes the `additional_flags` parameter to the `docker` function be optional, to avoid this breakage.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…pache#13238) This parameter was introduced in apache#12833, and was passed for all subcommands defined using `generate_command`. However, this broke the `ci.py lint` subcommand. This PR makes the `additional_flags` parameter to the `docker` function be optional, to avoid this breakage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter was introduced in #12833, and was passed for all subcommands defined using
generate_command. However, this broke theci.py lintsubcommand. This PR makes theadditional_flagsparameter to thedockerfunction be optional, to avoid this breakage.