Skip to content

Conversation

@nverke
Copy link
Contributor

@nverke nverke commented Nov 3, 2022

Pretty straight forward addition of logging to the to comparator so that its clear why tensor intrins are not matching.

cc @csullivan

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 3, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: tensorize See #10317 for details
  • Built docs for commit afc4b48 can be found here.

Generated by tvm-bot

@github-actions github-actions bot requested a review from csullivan November 3, 2022 21:40
Copy link

@shingjan shingjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nverke nverke changed the title [Tensorize] Add logs to comparator to make debugging tensorize failures easier. [Tensorize] Add logs to comparator to make debugging tensorize failures easier Nov 4, 2022
@nverke
Copy link
Contributor Author

nverke commented Nov 4, 2022

@tvm-bot rerun

@masahi masahi merged commit be44e9c into apache:main Nov 4, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
…es easier (apache#13285)

* [TIR][Tensorize] Add error logs to IR comparator to display what caused tensorization to fail

* lint issues
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…es easier (apache#13285)

* [TIR][Tensorize] Add error logs to IR comparator to display what caused tensorization to fail

* lint issues
@nverke nverke deleted the add_comparator_logs branch January 13, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants