-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TIR] Introduce ReduceBranchingThroughOvercompute #13299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
af7d704 to
2322fea
Compare
This PR introduces a new transform, which attempts to reduce branching by adding overcompute, where the overcompute has provably no effect on any observable value outside the PrimFunc.
2322fea to
6049696
Compare
These extensions aren't necessary for default operation, and would frequently be done in earlier simplification steps.
|
@csullivan This PR is ready for review and passing all unit tests, if you have a chance to review. |
csullivan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small removal and this looks good to go.
|
@tvm-bot rerun |
|
hi @Lunderberg , did we implement |
|
@LeiWang1999 That said, in most cases it's better to apply |
This PR introduces a new transform, which attempts to reduce branching by adding overcompute, where the overcompute has provably no effect on any observable value outside the PrimFunc.