[TVMC] Global pass context for compile and tune #13309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Contributor
Author
Comes as a followup from conversations in apache#13216. By making the pass context a global value for both `compile` and `tune` commands, we can ensure the pass context is exactly as the user expected and also test components such as `convert_graph_layout` under a pass context suitable for testing (e.g. add instruments). With this change, it becomes the users responsibility to ensure the PassContext they select is suitable for the passes that will be run. By default, `opt_level` remains as 3 so current workflows that do not alter the pass context from the command line / TVMC Python API should not be affected. Change-Id: I7a601daf6fbe664f77bce1b45efeb7ca29f621b3
lhutton1
force-pushed
the
global-pass-context
branch
from
e097d3e to
84c6fa3
Compare
Change-Id: I04f5bd031ae4717825f42e373bcb0e1e2c1c9d90
lhutton1
force-pushed
the
global-pass-context
branch
from
6012b8b to
e685e91
Compare
Contributor
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [TVMC] Global pass context for compile and tune Comes as a followup from conversations in apache#13216. By making the pass context a global value for both `compile` and `tune` commands, we can ensure the pass context is exactly as the user expected and also test components such as `convert_graph_layout` under a pass context suitable for testing (e.g. add instruments). With this change, it becomes the users responsibility to ensure the PassContext they select is suitable for the passes that will be run. By default, `opt_level` remains as 3 so current workflows that do not alter the pass context from the command line / TVMC Python API should not be affected. Change-Id: I7a601daf6fbe664f77bce1b45efeb7ca29f621b3 * fix vitis-ai test and typo Change-Id: I04f5bd031ae4717825f42e373bcb0e1e2c1c9d90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes as a followup from conversations in #13216. By making the pass context a global value for both
compileandtunecommands, we can ensure the pass context is exactly as the user expected and also test components such asconvert_graph_layoutunder a pass context suitable for testing (e.g. add instruments). With this change, it becomes the users responsibility to ensure the PassContext they select is suitable for the passes that will be run. By default,opt_levelremains as 3 so current workflows that do not alter the pass context from the command line / TVMC Python API should not be affected.