Skip to content

Conversation

@driazati
Copy link
Member

@driazati driazati commented Nov 7, 2022

This is a follow on to tlc-pack/ci#58 and #13300. This removes the old Jenkinsfile and makes the new job statuses required for PRs to merge.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 7, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@driazati driazati marked this pull request as ready for review November 29, 2022 20:50
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just thinking that we should place these in a single location or update our "how to add a new CI image" guide too

@driazati
Copy link
Member Author

driazati commented Dec 7, 2022

just thinking that we should place these in a single location or update our "how to add a new CI image" guide too

I wanted to make the CI images read from a text file at runtime instead of hardcoded in the jenkinsfile, that way any change of the image tags will actually be tested, we can fix up the docs along with that

@driazati driazati merged commit 1a99d75 into apache:main Dec 7, 2022
Liam-Sturge added a commit to Liam-Sturge/tlcpack that referenced this pull request Jun 16, 2023
Since work was completed to split up Jenkins in to platform-specific
jobs (PR: apache/tvm#13316), the pipeline for
validating the docker images with tests has been failing.

This validation pipeline is no longer needed and can be disabled,
however in doing so, it causes a failure of the
`daily-docker-image-rebuild` pipeline, which triggers the validation
pipeline to be run if the build is successful. This is because the
validation pipeline relied on the file `JenkinsFile`, which was removed
as part of the changes mentioned above.

In order to resolve the build errors for the daily docker rebuild, it is
necessary to remove the trigger for the validation pipeline.
leandron pushed a commit to tlc-pack/tlcpack that referenced this pull request Jun 16, 2023
Since work was completed to split up Jenkins in to platform-specific
jobs (PR: apache/tvm#13316), the pipeline for
validating the docker images with tests has been failing.

This validation pipeline is no longer needed and can be disabled,
however in doing so, it causes a failure of the
`daily-docker-image-rebuild` pipeline, which triggers the validation
pipeline to be run if the build is successful. This is because the
validation pipeline relied on the file `JenkinsFile`, which was removed
as part of the changes mentioned above.

In order to resolve the build errors for the daily docker rebuild, it is
necessary to remove the trigger for the validation pipeline.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…he#13316)

This is a follow on to tlc-pack/ci#58 and apache#13300. This removes the old `Jenkinsfile` and makes the new job statuses required for PRs to merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants