[TIR][Schedule] Fix cache_read loc detecting and region_cover checking #13345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
multiverstack-intellif
force-pushed
the
cache
branch
from
97d9f7c to
ed2157c
Compare
Member
|
Could you please add a regression testcase? |
Member
|
@wrongtest-intellif would you like to review this PR? Thanks! |
multiverstack-intellif
force-pushed
the
cache
branch
2 times, most recently
from
5ec4a89 to
992d5d3
Compare
multiverstack-intellif
force-pushed
the
cache
branch
from
992d5d3 to
c2d0efc
Compare
Contributor
Author
Test case added. |
wrongtest-intellif
approved these changes
Nov 11, 2022
Contributor
wrongtest-intellif
left a comment
wrongtest-intellif
left a comment
There was a problem hiding this comment.
LGTM. It works well for my workloads, thanks very mush!
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
apache#13345) Fix 2 issues of cache related primitives: * Fix region_cover checking for cache related primitives * Fix CacheLocDetector for nested SeqStmt Co-authored-by: Min Chen <chen.min@intellif.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 issues of cache related primitives:
cc @Hzfengsy @wrongtest-intellif