Skip to content

Conversation

@Icemist
Copy link
Contributor

@Icemist Icemist commented Nov 10, 2022

The main items that have been added are:

tvm.tir.analysis.calculate_allocated_bytes()

to calculate allocated memory per memory scope

tir.transform.VerifyVTCMLimit(limit)

to verify if the size of the allocated vtcm memory satisfies the limit

tvm.target.hexagon().vtcm_capacity

attribute to pass the limit

tir.vtcm_capacity

context configuration attribute to pass the limit alternatively

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 10, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Icemist Icemist changed the title Add vtcm memory capacity verification for Hexagon target [TIR][Hexagon] Add vtcm memory capacity verification for Hexagon target Nov 10, 2022
@Icemist
Copy link
Contributor Author

Icemist commented Nov 10, 2022

CC @masahi @csullivan

@TejashShah
Copy link

cc @kparzysz-quic @janetsc

@Icemist Icemist force-pushed the avoronov/verify_vtcm_limit branch from 1d27757 to 381beff Compare November 15, 2022 15:36
@Icemist Icemist force-pushed the avoronov/verify_vtcm_limit branch 6 times, most recently from 0f28d46 to eec33e0 Compare November 23, 2022 14:36
@Icemist Icemist marked this pull request as ready for review November 23, 2022 14:36
@Icemist Icemist force-pushed the avoronov/verify_vtcm_limit branch 4 times, most recently from 8bca070 to 825aa9c Compare November 25, 2022 00:37
@Icemist Icemist force-pushed the avoronov/verify_vtcm_limit branch from 825aa9c to a2040db Compare December 1, 2022 11:16
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Icemist Icemist force-pushed the avoronov/verify_vtcm_limit branch from 3710f4e to 63a403f Compare December 1, 2022 14:56
Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the helpful analysis pass @Icemist

@csullivan csullivan merged commit afbfb7a into apache:main Dec 1, 2022
@csullivan
Copy link
Contributor

Thank you @Icemist, @adstraw, @echuraev @janetsc, @masahi for the great discussion and changes, this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants